Skip to content

refactor: Enforce arrayRef regex & Handling and XML Spacing Rules#3900

Merged
MelReyCG merged 29 commits intodevelopfrom
bugfix/dudes/rtt-sourceflux
Feb 9, 2026
Merged

refactor: Enforce arrayRef regex & Handling and XML Spacing Rules#3900
MelReyCG merged 29 commits intodevelopfrom
bugfix/dudes/rtt-sourceflux

Conversation

@arng40
Copy link
Copy Markdown
Contributor

@arng40 arng40 commented Nov 4, 2025 •
edited
Loading

To reference an array of groups aka groupNameRefArray, we ensure we have to write attribute="{*}" .
We cannot longer write for example : attribute="*"

Also allow to have spaces spaces before and after a value in an attribute :

someAttributes="{ 0.0, 1.0, 10.0, 100.0 }"
coordinates="   { 0.0, 1.0, 10.0, 100.0 }"

@arng40 arng40 self-assigned this Nov 4, 2025
@arng40 arng40 changed the title Enforce arrayRef regex Enforce arrayRef regex & loosens xml spacing rules Nov 4, 2025
@arng40 arng40 changed the title Enforce arrayRef regex & loosens xml spacing rules refactor: Enforce arrayRef regex & loosens xml spacing rules Nov 4, 2025
@arng40 arng40 changed the title refactor: Enforce arrayRef regex & loosens xml spacing rules refactor: Enforce arrayRef regex & Handling and XML Spacing Rules Nov 5, 2025
@arng40 arng40 added ci: run CUDA builds Allows to triggers (costly) CUDA jobs ci: run integrated tests Allows to run the integrated tests in GEOS CI labels Nov 12, 2025
MelReyCG
MelReyCG requested changes Dec 5, 2025
View reviewed changes
MelReyCG
MelReyCG requested changes Dec 29, 2025
View reviewed changes
MelReyCG
MelReyCG requested changes Dec 29, 2025
View reviewed changes
@arng40 arng40 requested a review from MelReyCG January 21, 2026 15:14
MelReyCG
MelReyCG requested changes Feb 5, 2026
View reviewed changes
Copy link
Copy Markdown
Contributor

@MelReyCG MelReyCG left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

please address last comment

dkachuma
dkachuma approved these changes Feb 5, 2026
View reviewed changes
@MelReyCG MelReyCG added the ci: run code coverage enables running of the code coverage CI jobs label Feb 9, 2026
@codecov
Copy link
Copy Markdown

codecov bot commented Feb 9, 2026 •
edited
Loading

Codecov Report

❌ Patch coverage is 97.67442% with 2 lines in your changes missing coverage. Please review.
✅ Project coverage is 58.89%. Comparing base (7cca97c) to head (539f224).
⚠️ Report is 1 commits behind head on develop.

Files with missing lines Patch % Lines
...onents/dataRepository/unitTests/testXmlWrapper.cpp 97.26% 2 Missing ⚠️
Additional details and impacted files 
@@             Coverage Diff             @@
##           develop    #3900      +/-   ##
===========================================
+ Coverage    58.87%   58.89%   +0.02%     
===========================================
  Files         1353     1353              
  Lines       112964   113035      +71     
===========================================
+ Hits         66504    66573      +69     
- Misses       46460    46462       +2

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@jhuang2601 jhuang2601 added the flag: no rebaseline Does not require rebaseline label Feb 9, 2026
@MelReyCG MelReyCG merged commit 5abf149 into develop Feb 9, 2026
22 checks passed
@MelReyCG MelReyCG deleted the bugfix/dudes/rtt-sourceflux branch February 9, 2026 22:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@dkachuma dkachuma dkachuma approved these changes

@MelReyCG MelReyCG MelReyCG approved these changes

@herve-gross herve-gross herve-gross approved these changes

@jhuang2601 jhuang2601 jhuang2601 approved these changes

@rrsettgast rrsettgast Awaiting requested review from rrsettgast rrsettgast is a code owner

@castelletto1 castelletto1 Awaiting requested review from castelletto1

@OmarDuran OmarDuran Awaiting requested review from OmarDuran OmarDuran is a code owner

@corbett5 corbett5 Awaiting requested review from corbett5 corbett5 is a code owner

@wrtobin wrtobin Awaiting requested review from wrtobin wrtobin is a code owner

Assignees

@arng40 arng40

Labels

ci: run code coverage enables running of the code coverage CI jobs ci: run CUDA builds Allows to triggers (costly) CUDA jobs ci: run integrated tests Allows to run the integrated tests in GEOS CI flag: no rebaseline Does not require rebaseline flag: ready for review type: cleanup / refactor Non-functional change (NFC)

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

5 participants

@arng40 @herve-gross @jhuang2601 @dkachuma @MelReyCG